First Release.

Short Description:

In our first release our main goal was to become more familiar with GitHub. The most important part was to set up connection with our github account and repository of the project. After that we need to pick up a file and change “var” to “const” or “let”. After all necessary changes were made we need to run a test and check if everything works fine. In a last part we need to make a pull-request to master branch and run test again on github.

Git commands I used to finish first release:

  • git config –global user.name
  • git config –global user.email
  • git init
  • git remote add upstream
  • git clone
  • git checkout -b
  • git status
  • git add
  • git commit -m
  • git push

Final part:

Last part of first release was review of other people pull-requests. To finish this part i pick a pull-request. After that “File changed”. Went through the code to see if there are any places for improvements or errors. Checked if all tests was done and if they had an errors. In my case everything was fine accept one line was missing (“‘use strict’;”). I left a comment about that in pull-request.

Links:

Link to PR: https://github.com/filerjs/filer/pull/705

Link to Issue: https://github.com/filerjs/filer/issues/714

Link to Pull-Request: https://github.com/filerjs/filer/pull/732

Advertisements

Leave a Reply

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out /  Change )

Google photo

You are commenting using your Google account. Log Out /  Change )

Twitter picture

You are commenting using your Twitter account. Log Out /  Change )

Facebook photo

You are commenting using your Facebook account. Log Out /  Change )

Connecting to %s